Add view limit level parameter when show skeleton#31
Open
TaQuangTu wants to merge 3 commits intoFaltenreich:masterfrom
Open
Add view limit level parameter when show skeleton#31TaQuangTu wants to merge 3 commits intoFaltenreich:masterfrom
TaQuangTu wants to merge 3 commits intoFaltenreich:masterfrom
Conversation
Owner
|
Thanks for your PR and sorry for the late response! Is this feature still required and if so, could you explain one simple use case, so that I am able to understand the requirements? Thanks in advanca and all the best! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see that showing skeleton for all leaf views (views at the bottom of the view tree and have no children) is not always give a good look. I have added a field named
limitToLevel: Int(default = MAX_INT) to limit the depth at which child views in the SkeletonLayout should show skeleton and stop traveling down to their child views to show skeleton. This change does not require coders to modify their code except when they need to use the parameter. I hope you will consider my tiny effort. Thank you!