Merged
Conversation
ZenGround0
reviewed
Mar 15, 2025
ZenGround0
reviewed
Mar 15, 2025
ZenGround0
approved these changes
Mar 15, 2025
Contributor
ZenGround0
left a comment
There was a problem hiding this comment.
After a quick readthrough LGTM
rjan90
approved these changes
Mar 20, 2025
Contributor
rjan90
left a comment
There was a problem hiding this comment.
Looks good to me. Just added TOC's to the markdown files.
Comment on lines
+1
to
+2
| # Processor Architecture | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| # Processor Architecture | |
| # Processor Architecture | |
| ## Table of Contents | |
| - [Overview](#overview) | |
| - [Data Flow](#data-flow) | |
| - [Processing Pipeline](#processing-pipeline) | |
| - [Error Handling](#error-handling) | |
| - [Configuration](#configuration) | |
| - [Example Configuration](#example-configuration) | |
Contributor
|
Hey @silent-cipher! Wondering if you think the latest proposed changes here look okay? Would be nice to get this merged soon |
Co-authored-by: Phi-rjan <orjan.roren@gmail.com>
Co-authored-by: Phi-rjan <orjan.roren@gmail.com>
Co-authored-by: Phi-rjan <orjan.roren@gmail.com>
Co-authored-by: Phi-rjan <orjan.roren@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #8. Changes it includes are -
indexer( processor and reorg handling )openapispecifications for server routes