Skip to content

Fix/removal nextpp error#45

Merged
ZenGround0 merged 8 commits intomainfrom
fix/removal-nextpp-error
Apr 3, 2025
Merged

Fix/removal nextpp error#45
ZenGround0 merged 8 commits intomainfrom
fix/removal-nextpp-error

Conversation

@ZenGround0
Copy link
Contributor

Call pdpVerifier at the previous block's state in order to get correct values out of findRoot.

@ZenGround0 ZenGround0 requested a review from silent-cipher April 2, 2025 06:15
@rjan90 rjan90 added this to PDP Apr 2, 2025
@rjan90 rjan90 moved this to 🔎 Awaiting review in PDP Apr 2, 2025
Copy link
Collaborator

@silent-cipher silent-cipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

) ([]int64, error) {

callOpts := &bind.CallOpts{Context: ctx}
callOpts := &bind.CallOpts{Context: ctx, BlockNumber: blockNumber}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its easy to directly specify blockNumber as callOpts

@ZenGround0 ZenGround0 merged commit 5ac2043 into main Apr 3, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 Awaiting review to 🎉 Done in PDP Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

2 participants