Renamed "chief map analyst" to "map manager" to avoid any setflag conflict#170
Open
Renamed "chief map analyst" to "map manager" to avoid any setflag conflict#170
Conversation
ClashGone
requested review from
BenjamonSRL,
Jurorno9,
Rotelanin and
spentcud
Contributor
|
Isn’t the map discord bot also named map manager? |
Member
Author
Yeah lol I completely forgot :android:, well I guess if we consider Map Manager bot is the ultimate map manager then this is a valid role name /shrug |
Member
|
I don't think "map manager" is a good name... can be confused with Manager, the bot has the same name, and I think chief map analyst is more accurate There's an issue with the commands resolution that needs to be fixed, src/frameworks/commands/commands.ts:234 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.