Conversation
Add CI pipeline Add code coverage Add stryker
Flash0ver
added
changelog:none
| # Created by https://www.toptal.com/developers/gitignore/api/git,linux,macos,csharp,fsharp,windows,aspnetcore,dotnetcore,jetbrains+all,visualstudiocode | ||
| # Edit at https://www.toptal.com/developers/gitignore?templates=git,linux,macos,csharp,fsharp,windows,aspnetcore,dotnetcore,jetbrains+all,visualstudiocode |
There was a problem hiding this comment.
I usually use the latest .gitignore from the .NET SDK.
Does this .gitignore provide something that the .NET SDK's .gitignore is missing?
Or is it alright - from your perspective - to keep the current version?
| @@ -0,0 +1,8 @@ | |||
| stryker-config: | |||
There was a problem hiding this comment.
Is it viable to move the stryker-config.yaml from source/gen/ to source/?
My argument is that this file is not directly consumed by the FlashOWare.Generators.csproj, but rather brining it, the tests and the solution together.
I guess we would need to update the .sln and the .yml as well.
What do you think?
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "FlashOWare.Generators.Tests", "tests\FlashOWare.Generators.Tests\FlashOWare.Generators.Tests.csproj", "{998580C9-1518-43A8-A91B-B4C3D6B25B18}" | ||
| EndProject | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "_solution items", "_solution items", "{04634A03-F288-4A1B-9F81-258F23537516}" |
There was a problem hiding this comment.
My final pet peeve 😉:
Would you mind renaming this solution folder from _solution items to _SolutionItems?
So that it still shows up on the top, but has a more ".NET-ty" name.
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "FlashOWare.Generators.Tests", "tests\FlashOWare.Generators.Tests\FlashOWare.Generators.Tests.csproj", "{998580C9-1518-43A8-A91B-B4C3D6B25B18}" | ||
| EndProject | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "_solution items", "_solution items", "{04634A03-F288-4A1B-9F81-258F23537516}" |
There was a problem hiding this comment.
For completeness, please add 3 additional sub-solution-folders (to be on the same level as .github)
.configdocsresources
and include the contained files as well.
There was a problem hiding this comment.
Current main has enabled Artifacts output layout:
<PropertyGroup>
+ <UseArtifactsOutput>true</UseArtifactsOutput>
- <!--<ArtifactsPath>$(MSBuildThisFileDirectory)artifacts</ArtifactsPath>-->
+ <ArtifactsPath>$(MSBuildThisFileDirectory)../artifacts</ArtifactsPath>
</PropertyGroup>Could this cause problems with the CI-workflow?
2 participants
resolves #2 (first part)
This PR adds CI support for code coverage and mutation testing.
In addition to the requirements, it adds reporting of the code coverage and mutation testing to the PR and the GitHub-Action summary as Markdown. Another difference is that the job
Collect Code Coveragedoes notrestore .NET local toolsand instead performs a restore of the NuGet packages. Coverlet is installed as a project reference and not as a tool therefore the normal NuGet package restore is sufficient.