Introduce Catching protocol for convenient nesting of error types for typed throws#19
Merged
Introduce Catching protocol for convenient nesting of error types for typed throws#19
Catching protocol for convenient nesting of error types for typed throws#19Conversation
n0rthk1n9
approved these changes
Jan 19, 2025
Collaborator
n0rthk1n9
left a comment
There was a problem hiding this comment.
Pretty clever way of reducing boilerplate and simplifying tedious error handling! I like it. This looks good to me, can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18.
You might want to review #14 first, this builds upon it (but the "Files changed" tab doesn't contain any changes from the other PR because I targeted this towards that branch so you only see the changes of this PR).