Fix artefact hash discrepancy for WinGet release#2218
Conversation
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view or the 📜action log for details. Unrecognized words (1)occurr To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands... in a clone of the git@github.com:Flow-Launcher/Flow.Launcher.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/5450537806/attempts/1'To have the bot do this for you, reply quoting the following line: If the flagged items are 🤯 false positivesIf items relate to a ...
|
|
I'm quite sure the first Github deployment job will still run on tag CI builds and update the artifacts of the release. Therefore this does not solve the Winget issue... See for example this CI job for tag v1.15.0 If you see the very end of the log, it is updating the existing v1.15.0 release artifacts on github, twice. |
|
Perhaps a simpler temporary solution would be to switch the winget release action to manual only? And trigger it manually when both appveyor jobs have finished... |
|
Ah yes, does look like the case. Yes lets change the WinGet action to manual temporarily. |
Context:
Currently project is rebuilt and output artefacts re-uploaded after marking a draft release as latest. This creates a discrepancy for WinGet publish process. #2086
Solution:
Tag is created after marking a draft release as prerelease or latest. No need to upload the artefacts again on tag.
If changes need to occurr during release process, delete draft then merge new changes in.
Related #2185