-
-
Notifications
You must be signed in to change notification settings - Fork 23.6k
Implement proprietary path guardrails in GitHub workflows and pre-push hooks #5703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…h hooks - Added a GitHub Actions workflow to check for proprietary paths in pull requests and pushes. - Introduced a pre-push hook to prevent pushing files from proprietary paths to the OSS repository. - Updated .gitignore to restrict certain application paths and added comments for clarity.
Summary of ChangesHello @jocelynlin-wd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes robust mechanisms to safeguard against the accidental inclusion of proprietary code within the open-source repository. By integrating both CI/CD checks and local pre-push hooks, it creates a multi-layered defense system designed to enforce strict separation between proprietary and open-source assets, thereby maintaining the integrity and compliance of the OSS project. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces guardrails to prevent proprietary code from being pushed to the open-source repository by updating .gitignore and adding a pre-push hook. The changes are well-structured and the .gitignore update correctly blocks the intended paths. The new pre-push hook is functional, but I've identified an opportunity to significantly improve its performance and simplify the code. My review includes a specific suggestion to replace an inefficient shell loop with a more idiomatic and performant grep pipeline.
Limit GITHUB_TOKEN to read-only access for security best practices. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace per-file loop with efficient grep operations. Removes is_proprietary function in favor of direct pattern matching. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add || true to grep commands to prevent exit code 1 (no match) from aborting the subshell when husky's set -e is active. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Tested pre-push with following scenarios: