Add support for flutter shaders#596
Draft
YaroCabbage wants to merge 2 commits intoFlutterGen:mainfrom
Draft
Conversation
0f49f09 to
1a866f2
Compare
1a866f2 to
472c384
Compare
AlexV525
reviewed
Nov 2, 2024
Member
AlexV525
left a comment
There was a problem hiding this comment.
Just a quick look on my phone without reviewing generators implementation.
- reverted manual version bump - shaders placed after fonts
Author
Fixed @AlexV525 |
Member
|
Just had a complete review of the request.
Indeed. Shaders are mostly a sub-implementation to the assets so far. We may have some abstractions so assets and shaders can use both. However, we can also use the assets generator for shaders by tweaking some parameters. These APIs are just internally used so that we can refactor them anytime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Flutter has had shader support for quite some time now. However, this package does not implement working with them. This PR aims to solve this problem.
I had to make this addition quickly, perhaps it is too rough, but still there was an attempt to do the maximum. I apologize for not creating an issue.
I added support even for what Flutter itself most likely has not implemented yet - flavor for shaders, but nevertheless. According to the settings, I implemented an almost complete copy of regular assets. It would be possible to simply pass shaders to the asset generator, but I decided to make a copy - perhaps this is excessive.
Type of change
Please delete options that are not relevant.
Checklist:
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
melos run test)melos run formatto automatically apply formatting)