Fixed compile-problems against latest axios 1.6.0#260
Open
FibreFoX wants to merge 1 commit intoFlyrell:masterfrom
Open
Fixed compile-problems against latest axios 1.6.0#260FibreFoX wants to merge 1 commit intoFlyrell:masterfrom
FibreFoX wants to merge 1 commit intoFlyrell:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that never versions of axios require a different type to be used for interceptors, so I replaced them all.
Interestingly the resulting JS is the same as before.
The
@types/nodeupdate was neccessary due to AbortSIgnal not working otherwise when compiling this on lates LTS version of NodeJS. Mabye this needs anengineentry too to only allow more modern versions?I do not expect this PR to be accepted, but maybe some parts can be used for an upgrade.