feat: allow different resource configuration for idle#398
Open
Wandang wants to merge 3 commits intoFoldingAtHome:masterfrom
Open
feat: allow different resource configuration for idle#398Wandang wants to merge 3 commits intoFoldingAtHome:masterfrom
Wandang wants to merge 3 commits intoFoldingAtHome:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario I wanted to tackle:
When I am working on my PC I want to share a bit of my compute for the foldingathome project. But when I am idling I would like to share much more compute with the foldingathome project.
The frontend and backend would not allow this to be configured, so I added the configuration in both projects(Frontend PR).
I am normally used to nestJS and typescript for the backend, so I used AI to assist me with the task. The code looks correct to me (I did a bit of cpp over 10 years ago). I tested it locally by adding a button in the frontend that would toggle a mock idle state in the backend
The idea for this solution was adding 2 flags in the configuration that mimics the old behavior:
cpus_idle
gpus_idle
and 1 new flag that controls which resources are taken at idle time:
different_idle_resources