Security fix: Prevent command injection in Bash tool (Issue #1931) #1940
+841
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…njection - Add command validation with safe command allowlist - Block dangerous patterns (curl, wget, rm -rf, sudo, etc.) - Prevent shell metacharacters and command substitution - Add comprehensive validation tests - Fixes issue FoundationAgents#1931 - Command Injection via Bash.run() LLM Tool Registration The Bash class was previously exposed to LLM agents without any validation, allowing arbitrary command execution via prompt injection attacks. This fix implements strict input validation while preserving legitimate functionality. Security improvements: - Allowlist of safe commands (ls, git, python3, custom shell functions, etc.) - Regex patterns to detect dangerous commands and shell metacharacters - Proper error messages when commands are blocked - Comprehensive test coverage for validation logic This maintains backward compatibility for legitimate uses while preventing Remote Code Execution attacks via malicious LLM prompts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes critical RCE vulnerability in Bash tool exposed to LLM agents.
Fixes #1931