Open
Conversation
Contributor
|
I think we could make it more clear what is good and what is bad. void f1(const string& s); // OK: pass by reference to const; always cheap
void f2(string s); // bad: potentially expensive
void f3(int x); // OK: Unbeatable
void f4(const int& x); // bad: overhead on access in f4()in this case it could look like: auto value = randomThing.weirdProperty->getValue(); // bad: non-obvious type
long value = randomThing.weirdProperty->getValue(); // OK: type is specified, no need to guess type |
benj5378
approved these changes
May 2, 2025
Contributor
|
@pieterhijma are you going to update this? |
5440076 to
5f3f759
Compare
Contributor
Author
Yes, I just did :) |
Contributor
Author
|
@hyarion, could you please review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make a small fix in reaction to this feedback by @benj5378.