Add Parental Control toggle to disable channel link from videos#8502
Open
ozrendev wants to merge 1 commit intoFreeTubeApp:developmentfrom
Open
Add Parental Control toggle to disable channel link from videos#8502ozrendev wants to merge 1 commit intoFreeTubeApp:developmentfrom
ozrendev wants to merge 1 commit intoFreeTubeApp:developmentfrom
Conversation
github-actions
bot
added
the
PR: waiting for review
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
Member
indeed best to kept separate and add it to the Side bar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
closes #8375
Description
Adds a toggle under Parental Control that allows the user to disable the channel link from video thumbnails.
Testing
Go to Settings -> Parental Control -> Enabled "Disable Channel Link on Videos"
View any video thumbnail and see that channel link can't be clicked and no longer appears as a link
Additional context
The original issue called for also hiding the "Channels" button in the side bar, but I feel like this should be a separate PR since I think it makes the most sense to be another toggle under "Distraction Free -> Side Bar"
I'm not 100% sure on this, so wanted to add this here for feedback?