Improve forced RSS and RSS enabled handling#8607
Improve forced RSS and RSS enabled handling#8607absidue wants to merge 2 commits intoFreeTubeApp:developmentfrom
Conversation
|
Not sure if that dim out effect on specific profiles would confuse users |
There was a problem hiding this comment.
Taken from issue
Visually grey out the toggle after the user first receives the RSS is forced message. This way, the message will only be displayed once, rather than every time.
Show toast once per tab per session
Also like discussed update the message at
https://github.com/FreeTubeApp/FreeTube/blob/development/static/locales/en-US.yaml#L128
To: “RSS is forced for profiles with 125 or more subscriptions to avoid rate limiting.”
| Subscriptions Tabs: Subscriptions Tabs | ||
| All Subscription Tabs Hidden: 'All subscription tabs are hidden. To see content here, please unhide some tabs in the "{subsection}" section in "{settingsSection}".' | ||
| Posts: | ||
| RSS Message: The "{setting}" setting is enabled and YouTube does not provide RSS feeds for posts. |
There was a problem hiding this comment.
| RSS Message: The "{setting}" setting is enabled and YouTube does not provide RSS feeds for posts. | |
| RSS Message: The "{setting}" setting is enabled, but YouTube does not provide RSS feeds for posts. To view posts, disable this setting. To hide this tab, go to the "{subsection}" section in "{settingsSection}". |
| All Subscription Tabs Hidden: 'All subscription tabs are hidden. To see content here, please unhide some tabs in the "{subsection}" section in "{settingsSection}".' | ||
| Posts: | ||
| RSS Message: The "{setting}" setting is enabled and YouTube does not provide RSS feeds for posts. | ||
| Forced RSS Message: This profile has a large number of subscriptions. Forcing RSS to avoid rate limiting. YouTube does not provide RSS feeds for posts. |
There was a problem hiding this comment.
| Forced RSS Message: This profile has a large number of subscriptions. Forcing RSS to avoid rate limiting. YouTube does not provide RSS feeds for posts. | |
| Forced RSS Message: RSS is forced for profiles with 125 or more subscriptions to avoid rate limiting. YouTube does not provide RSS feeds for posts. To disable forced RSS, reduce your subscription count or split your subscriptions across multiple profiles. To hide this tab, go to the "{subsection}" section in "{settingsSection}". |
There was a problem hiding this comment.
To disable forced RSS, reduce your subscription count or split your subscriptions across multiple profiles.
I would also like to link profiles to https://docs.freetubeapp.io/usage/profiles/
@PikachuEXE what about this: If users doesnt explicitly toggles RSS in the settings then it will be dimmed out and forced if limit is reached in profile A but when user switches to profile B that sits below the limit then the setting will be turned off |
Pull Request Type
Related issue
Description
Show the posts tab on the subscriptions with an explanation when "Fetch Feeds from RSS" or is force enabled because the current profile has too many subscriptions instead of hiding it. It also shows the "Fetch Feeds from RSS" setting as enabled and disables interaction with it when RSS is being forced.
Screenshots
With the "Fetch Feeds from RSS" setting enabled:

When the user has too many subscriptions

The "Fetch Feeds from RSS" setting when RSS is forced

Testing
Desktop