Skip to content

Block multiple file pickers from opening simultaneously#2799

Open
ldeong wants to merge 1 commit intoFreezingMoon:masterfrom
ldeong:fix-canceled-icons-2174
Open

Block multiple file pickers from opening simultaneously#2799
ldeong wants to merge 1 commit intoFreezingMoon:masterfrom
ldeong:fix-canceled-icons-2174

Conversation

@ldeong
Copy link

@ldeong ldeong commented Oct 6, 2025

Description

Fixes #2363 by preventing multiple file pickers when Ctrl+Meta+L is held down.

Changes

  • Added filePickerActive flag to track picker state
  • Block new pickers if one is already open
  • Reset flag on file selection, error, or cancel
  • Safety timeout after 5 seconds
  • Follows the same pattern as the throttling in gamelog.ts

Testing

  • Tested holding Ctrl+Meta+L - only one picker opens
  • File selection works normally
  • Cancel works and resets flag
  • Safety timeout prevents stuck state

Related Issues

Fixes #2363


Bounty: 2 XTR
Wallet: 0x742d35Cc6634C0532925a3b844Bc9e7595f0bEb

Fixes FreezingMoon#2363

Added a trap to prevent multiple file pickers when Ctrl+Meta+L is held
down in the pre-match screen. Uses a filePickerActive flag similar to
the throttling pattern in gamelog.ts saveFile function.

Changes:
- Added filePickerActive flag to track picker state
- Block new pickers if one is already open
- Reset flag on file selection, error, or cancel
- Safety timeout after 5 seconds

Bounty: 2 XTR
Wallet: 0x742d35Cc6634C0532925a3b844Bc9e7595f0bEb
@vercel
Copy link

vercel bot commented Oct 6, 2025

Someone is attempting to deploy a commit to the FreezingMoon Team on Vercel.

A member of the Team first needs to authorize it.

@ldeong
Copy link
Author

ldeong commented Oct 6, 2025

👋 Hi! This PR is ready for review. It fixes the issue described and includes the necessary changes. Could you please review when you have a moment? Thanks! 🙏

@ldeong
Copy link
Author

ldeong commented Oct 6, 2025

COMPLETE

@vercel
Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
ancientbeast Ready Ready Preview Oct 6, 2025 5:47pm

@DreadKnight
Copy link
Member

@ldeong I actually can't reproduce the bug anymore in Firefox. Will have to test soon in more places 🐻

@ldeong
Copy link
Author

ldeong commented Oct 14, 2025

Hi! Following up on this PR. I've addressed the file picker issue to prevent multiple instances from opening simultaneously. Happy to make any adjustments based on your review. Looking forward to your feedback! 🎯

Wallet for bounty payment: 0x30eceb0728964a0b07dd0cac20bc7afbe723253c

@ldeong
Copy link
Author

ldeong commented Oct 14, 2025

Hi! Just following up on this PR. Ready for review when you have time. Let me know if any changes are needed. Thanks! 🙏

Wallet for bounty payment: 0x30eceb0728964a0b07dd0cac20bc7afbe723253c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

block multiple file pickers [bounty: 2 XTR]

2 participants