Add a method that enables adding an Frc-Sdk component#6
Merged
greenberga merged 3 commits intomainfrom Mar 5, 2025
Merged
Conversation
This will allow SDKs that depend on the PHP SDK to add an identifier that identifies them.
greenberga
force-pushed
the
add-sdk-trailer-method
branch
from
bb0d982 to
b685902
Compare
greenberga
force-pushed
the
add-sdk-trailer-method
branch
from
b685902 to
ac4374c
Compare
gzuidhof
approved these changes
Mar 5, 2025
greenberga
force-pushed
the
add-sdk-trailer-method
branch
2 times, most recently
from
10ebf20 to
ac4374c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow SDKs that depend on the PHP SDK to add an identifier that identifies them.
PHPUnit v10 changed the implementation of Data Providers, so I updated the tests accordingly.