Conversation
* security fixes and theme preview * securit fix replace * Update CHANGELOG.md * 5.3.3 * namespace guide entfernt * fixed reload * Bump version to 5.3.4 and fix various issues Updated version to 5.3.4 and fixed multiple issues including JSON parsing errors, framework template loading, and security vulnerabilities. * 5.3.6 * alle laden inline via session erlauben * Fix iOS Safari touch events (thx @alexwenz) and update changelog * Address review comments: add missing translations and secure host usage
…_cssjs.php (#460) * Initial plan * fix(security): Add missing nonce attributes to all script tags in box_cssjs.php Co-authored-by: skerbis <791247+skerbis@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: skerbis <791247+skerbis@users.noreply.github.com>
…5 (ours strategy)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on security improvements and framework mode compatibility enhancements for the consent manager. The changes primarily add CSP nonce attributes to inline scripts and implement validation to prevent theme usage when framework mode is active.
Changes:
- Added CSP nonce attributes to inline script tags for improved XSS protection
- Implemented framework mode validation on the theme page to prevent incompatible configurations
- Made cookie name and lifetime configurable instead of hardcoded values
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pages/theme.php | Added framework mode validation check with error message and early return |
| pages/help.php | Added CSP nonce attribute to inline script tag |
| package.yml | Updated version from 5.4.2 to 5.5.0-dev |
| lib/InlineConsent.php | Added CSP nonce attributes to generated script tags |
| lang/sv_se.lang | Added Swedish translation for framework mode active error message |
| lang/en_gb.lang | Added English translation for framework mode active error message |
| lang/de_de.lang | Added German translation for framework mode active error message |
| fragments/ConsentManager/inline_placeholder.php | Added CSP nonce attribute to script tag |
| fragments/ConsentManager/cookiedb.php | Changed from hardcoded 'consentmanager' to configurable cookie name |
| fragments/ConsentManager/box_cssjs.php | Changed from hardcoded values to configuration-based cookie name and lifetime |
| boot.php | Added CSP nonce attributes to debug script tags |
| CHANGELOG.md | Updated changelog to reflect version 5.5.0 development changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.