Fix avro serialization of union types#367
Open
DaveWM wants to merge 2 commits intoFundingCircle:masterfrom
Open
Fix avro serialization of union types#367DaveWM wants to merge 2 commits intoFundingCircle:masterfrom
DaveWM wants to merge 2 commits intoFundingCircle:masterfrom
Conversation
✅ SAST ReportNo issues found. Good job! 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for a bug in the avro serde, where serialization is sometimes ignoring default values that appear within a union type. This is only the case when the default value is
falseornil.The problem is that when
match-clj?is called for a record type (as it is withinUnionType'sclj->avromethod), it checks whether any fields missing from the clojure data have a default value in the avro schema. To do this it calls.defaultVal, but if the default value isnilorfalsethis returns falsey. I've therefore replaced this call with.hasDefaultValue.Checklist