Implement retries and ratelimiting#65
Open
Floppy012 wants to merge 2 commits intoFuzzyStatic:mainfrom
Open
Conversation
Owner
|
Can you add a small example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #38. The codebase has changed a bit since that PR was opened so I decided do make a new one. This PR is somewhat inspired by #38.
I've made some changes to make enabling/configuring the rate limiter / retries simpler. These two features are disabled by default. For the rate limiter I've added a var that contains a configuration that matches Blizzard's rate limits.
It probably needs some documentation in the readme file to make people aware of the features.
Disclaimer: I'm still learning golang :)