Update projectEntitlements.js project paths for cordova-ios@8 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since cordova ios 8 was released a few days ago, it would be great to merge this PR, otherwise the plugin will fail on install. |
|
@mmrosekgi Do you need help with this? We are using this plugin also for our deeplinks and noticed that they they broke after the upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the old project path, the entitlements file cannot be placed correctly by the hook. This is a backwards compatible fix done with this guide: https://apache.github.io/cordova-ios/documentation/cordova/upgrading-8#Change-to-the-generated-app-project-naming