refact: enhance state management and full typescript support #15
Conversation
AlexAndrei98
left a comment
AlexAndrei98
left a comment
There was a problem hiding this comment.
Thank you for cleaning up the code and actually make it fully typescript! ! It is much better organized!
| salty: Salty; | ||
| } | ||
|
|
||
| interface Salty { |
There was a problem hiding this comment.
I think these types can also be added to the native signify-ts client rather than in the web app itself! It would be awesome if you could make a pr here as well to add these!
There was a problem hiding this comment.
Sure! Thank you for pointing out to this!
|
I thought it would be more understandable for newcomers and much easier and less intimidating to add new features if the code was strongly typed and split into a hierarchy :) |
|
I plan to review/test this tonight or tomorrow |
All variables in shared-slice are related to authentication, thus, auth-slice is more semantic. We can have a shared-slice later if needed
|
I had some issues running the orig repo (and yours) but they are on my side. I'll come back to this soon. |
|
please reinstall dependencies using |
|
@2byrds have you had a chance to integration test this PR? |
|
No, I've been buried in other tasks. I'll try to revisit soon, thank you for the reminder! |
3 participants
cleaner and more readable code