Heat Sensor Refactor + IMETERenderer improvement#5727
Heat Sensor Refactor + IMETERenderer improvement#5727YamiKami-Sama wants to merge 11 commits intoGTNewHorizons:masterfrom
Conversation
…enderer and add possibility to transfer data for the client when required
85fc3f9 to
3f7851f
Compare
|
What do you intend to use the heat sensor for? This is a bit odd for sure |
|
I intend to use heat in a new multiblock, so i will reuse the heat sensor, that pr is mainly to extract refactoring/changing code that is not dirrectly related to the multi. |
|
Yes I understood the pr. Was just curious why you wanted to reuse the hatch |
src/main/java/gregtech/api/util/shutdown/ShutDownReasonRegistry.java
Outdated
Show resolved
Hide resolved
| */ | ||
| public interface IHeatProducer { | ||
|
|
||
| int getHeatSensorHatchNum(); |
There was a problem hiding this comment.
I don't really like this, it assumes all you will need to do with the hatch list is get its size. I would refactor this to instead be
List<MTEHeatSensor> getHeatSensorHatches();and let the caller figure out if it wants the size, to iterate over them, etc.
There was a problem hiding this comment.
I still think this should be done. This is an interface that will potentially be used by many multiblocks in the future, we should ensure that its API is flexible and maintainable.
| */ | ||
| public interface IHeatProducer { | ||
|
|
||
| int getHeatSensorHatchNum(); |
There was a problem hiding this comment.
I still think this should be done. This is an interface that will potentially be used by many multiblocks in the future, we should ensure that its API is flexible and maintainable.
|
it not build @YamiKami-Sama |
Refactor the Heat Sensor of the HIP to make it usable by other future machines and fix Heat Sensor outputing redstone signal on every face instead of facing one.
Implement some missing render function to the IMTERenderer to be able to sync some data used for render to client and configure the max render distance.