Improved error message when no search pattern is provided#527
Open
Vishal45718 wants to merge 2 commits intoGenivia:masterfrom
Open
Improved error message when no search pattern is provided#527Vishal45718 wants to merge 2 commits intoGenivia:masterfrom
Vishal45718 wants to merge 2 commits intoGenivia:masterfrom
Conversation
Author
|
Thanks for reviewing! |
Contributor
pierre-rouleau
left a comment
pierre-rouleau
left a comment
There was a problem hiding this comment.
Looks fine to me except that I would start the sentence with an uppercase 'N' as in:
"No search PATTENRN specified.\n\n"
Author
|
Thanks for the suggestion! Fixed and updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve UX when no search pattern is provided
This PR improves the error message shown when
ugrepis run without a searchpattern.
The previous message was technically correct but confusing for new users.
The updated message:
--helpNo behavior or logic changes are introduced.
All tests pass.