[Fixes #42] Dynamicully set CORS ALLOW ORIGINS#43
Open
t-book wants to merge 1 commit intoGeoNode:masterfrom
Open
[Fixes #42] Dynamicully set CORS ALLOW ORIGINS#43t-book wants to merge 1 commit intoGeoNode:masterfrom
t-book wants to merge 1 commit intoGeoNode:masterfrom
Conversation
|
@t-book while you are here, wouldn't it make sense to sync all CORS settings? https://pypi.org/project/django-cors-headers allows to configure more CORS settings which are configured in nginx also, e.g.
However, all these can be set from @giohappy sorry for not (yet) being convinced here :) |
|
Discussion is still going on: #42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@giohappy @ridoo
I'd suggest to add the header for now as geoserver does (with Tomcat). As said in the ticket django-cors-headers is enabled with django in case somebody uses some other fe server than nginx
My take on this is:
If
CORS_ALLOW_ALL_ORIGINS = Truehttps://github.com/GeoNode/geonode/blob/684a1f3572a39b6ab8ba5a6ce7ea4d96fc739c8c/.env.sample#L134
we set the wildcard and all origins will be allowed
Else the domain name of SITEURL will be set
https://github.com/GeoNode/geonode/blob/684a1f3572a39b6ab8ba5a6ce7ea4d96fc739c8c/.env.sample#L44