Skip to content

upgrade to react 19#121

Open
torsello wants to merge 1 commit intoGeorgeHop:masterfrom
torsello:upgrade/react-19
Open

upgrade to react 19#121
torsello wants to merge 1 commit intoGeorgeHop:masterfrom
torsello:upgrade/react-19

Conversation

@torsello
Copy link

🚀 Upgrade to React 19 - Support & Compatibility Fixes

Description

This PR updates the library to be fully compatible with React 19 and the latest version of React Native. The following changes were made:

🔹 Updated Type Imports

  • Added { JSX } to the import React statement to ensure correct JSX type resolution.

🔹 Updated package.json Dependencies

  • Upgraded @types/react to ^19.0.0.
  • Upgraded @types/react-native to ^0.73.0.
  • Added explicit dependencies for react and react-dom at ^19.0.0.

🔹 General Compatibility Fixes

  • Adjusted imports to align with changes introduced in React 19.

🛠 Why is this change needed?

With the release of React 19, some internal type changes and JSX handling require updates to ensure compatibility with the latest React Native ecosystem. This PR ensures that the package works seamlessly with modern React versions while maintaining backward compatibility.

✅ Testing

  • Verified compilation and functionality in a React Native project using React 19.
  • Confirmed that Modal and other React Native components work without issues.

⚠️ Breaking Changes

  • None expected. The update should be backward compatible with React 18 while adding support for React 19.

📌 Additional Notes

If the maintainers have specific guidelines for supporting multiple React versions, I’d be happy to adjust accordingly.


🔥 Looking forward to feedback and suggestions! 🚀

@sanjaydev02
Copy link

its working fine ?

@torsello
Copy link
Author

its working fine ?

Try with https://www.npmjs.com/package/react-native-dialer-code-picker

@badredaha
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants