Merged
Conversation
Collaborator
abradley60
commented
Jan 24, 2025
- Adding function to upload files in a local folder to a specified s3 bucket and folder
- The substructure of the specified folder will be maintained
- Adding a command line tool that can be called
- Added the default logging level of 'info' to the cli.py script
caitlinadams
requested changes
Jan 24, 2025
Collaborator
caitlinadams
left a comment
There was a problem hiding this comment.
Thanks for this Alex!
Before merging:
- Can you please update the environment.yml file to include boto3 and dependencies? I needed to do
pip install boto3to get it working - Perhaps include an option to allow a user to upload a whole folder (e.g.
my-folder/folder bucket my-s3-folderwould createmy-s3-folder/folderwhich contained the files)
Looks great and works well otherwise, so happy to approve :)
Collaborator
Author
|
@caitlinadams the following changes have been made:
Let me know if any other changes needed |
abradley60
pushed a commit
that referenced
this pull request
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.