Skip to content

Conversation

@clement-tourriere
Copy link
Contributor

Summary

  • Prevents docker scan stdout from leaking into JSON output, ensuring clean parseable JSON when using --json flag.

Test plan

  • Unit tests updated in tests/unit/verticals/secret/test_scan_docker.py

@clement-tourriere clement-tourriere requested a review from a team as a code owner February 9, 2026 10:23
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.05%. Comparing base (b0a6380) to head (5f6dc32).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1172   +/-   ##
=======================================
  Coverage   92.05%   92.05%           
=======================================
  Files         144      144           
  Lines        6254     6255    +1     
=======================================
+ Hits         5757     5758    +1     
  Misses        497      497           
Flag Coverage Δ
unittests 92.05% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but some changes seem unnecessary.

@clement-tourriere clement-tourriere merged commit 37820fd into main Feb 10, 2026
30 checks passed
@clement-tourriere clement-tourriere deleted the fix/docker-stdout-json branch February 10, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants