Add custom tags and make member_id optional#164
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 95.60% 95.63% +0.02%
==========================================
Files 5 5
Lines 1230 1236 +6
==========================================
+ Hits 1176 1182 +6
Misses 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kash-jay
force-pushed
the
kash-jay/add-custom-tags
branch
from
a170edc to
92e2e1a
Compare
agateau-gg
reviewed
Jan 26, 2026
Collaborator
agateau-gg
left a comment
agateau-gg
left a comment
There was a problem hiding this comment.
Looks good, but I am not sure we need to allow email to be null.
alexpasmantier
approved these changes
Jan 27, 2026
kash-jay
force-pushed
the
kash-jay/add-custom-tags
branch
from
e236532 to
85982b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the field
custom_tagsto the classSecretIncident, which was previously dropped since the field was absent. Themember_idand field ofFeedbackwas also made optional, as this was causing failures with ggshield when the field in the API response was empty.This should fix ggshield not receiving
custom_tagsinfo when scanning a known incident withcustom_tagsset.