Handle OIDC error responses in visitor-auth callback#1109
Draft
Handle OIDC error responses in visitor-auth callback#1109
Conversation
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
error/error_descriptioninstead of an authorizationcodeby forwarding the error to the published site rather than attempting a token exchange.Description
router.get('/visitor-auth/response')to detectrequest.query.errorand redirect to the published content URL witherrorand optionalerror_descriptionquery parameters.locationwhen building the redirect target so the user lands in the same location on the published site.500Responsewhen the site's published URL is missing.Testing
Codex Task