Skip to content

Add query param for language in Arcade embed #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
addisonschultz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add query param for language in Arcade embed #1114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/deep-spoons-throw.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@gitbook/integration-arcade': minor
---

Add query param for language
6 changes: 4 additions & 2 deletions integrations/arcade/src/arcade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,11 @@ export async function fetchArcadeOEmbedData(flowId: string): Promise<ArcadeOEmbe
}

/**
* Extract the Arcade flow ID from the embed URL.
* Extract the Arcade flow ID and language from the embed URL.
*/
export function extractArcadeFlowFromURL(input: string): {
flowId?: string;
language?: string;
} {
const url = new URL(input);
if (!['app.arcade.software', 'demo.arcade.software'].includes(url.hostname)) {
Expand All @@ -45,5 +46,6 @@ export function extractArcadeFlowFromURL(input: string): {
return {};
}

return { flowId: parts[2] };
const language = url.searchParams.get('language') ?? undefined;
return { flowId: parts[2], ...(language && { language }) };
}
6 changes: 4 additions & 2 deletions integrations/arcade/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ type ArcadeRuntimeContext = RuntimeContext<ArcadeRuntimeEnvironment>;
const embedBlock = createComponent<{
flowId?: string;
url?: string;
language?: string;
}>({
componentId: 'embed',

Expand All @@ -41,7 +42,7 @@ const embedBlock = createComponent<{

async render(element, context) {
const { environment } = context;
const { flowId, url } = element.props;
const { flowId, url, language } = element.props;

if (!flowId) {
return (
Expand Down Expand Up @@ -69,11 +70,12 @@ const embedBlock = createComponent<{

const embedData = await fetchArcadeOEmbedData(flowId);
const aspectRatio = embedData.width / embedData.height;
const embedUrl = `https://demo.arcade.software/${flowId}?embed${language ? `&language=${encodeURIComponent(language)}` : ''}`;
return (
<block>
<webframe
source={{
url: `https://demo.arcade.software/${flowId}?embed`,
url: embedUrl,
}}
aspectRatio={aspectRatio}
/>
Expand Down