Feat: deck layer composer tests #3641
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linkmetal
changed the title
j8seangel
requested changes
Jan 29, 2026
Collaborator
There was a problem hiding this comment.
There are 4 tests failing for me and I don't understand why, can you take a look?
See for example the log of layer: visible = true but then it fails
× should pass visible property from dataview config
BTW I've added a couple of commits, please review them too
| it('should create BaseMapImageLayer for BasemapImage type', () => { | ||
| const dataview = createMockDataview({ | ||
| config: { type: DataviewType.BasemapImage }, | ||
| datasets: [ |
Contributor
There was a problem hiding this comment.
maybe we could also create a mock dataset helper function?
| ) | ||
|
|
||
| await waitFor(() => { | ||
| expect(result.current).toHaveLength(1) |
Contributor
There was a problem hiding this comment.
here it looks like it is only validating if the layer exists, maybe we should check that dataviewToDeckLayer was called 3 times?
Collaborator
Author
There was a problem hiding this comment.
On line 165 is being asserted that the funcion is called once, it's only called once because it already handle the dataview with the 3 datasets merged
libs/deck-layer-composer/src/hooks/deck-layers-composer.hooks.spec.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.