Open
Conversation
Contributor
|
I'll review this tonight or tomorrow. |
Contributor
|
This looks to me a little too much like Aspect-Oriented Programming. How much use are stack traces going to be under this new regime? |
Member
Author
|
Do you think this could be better implemented in Java 9's Flow API? Also, I feel like it would make more sense to migrate to 1.13 first before doing such a massive change to our item/block type system. |
Member
Author
|
Closed because we're waiting for 1.13 and this branch will probably be rewritten by then |
Member
Author
|
Reopening this branch since it has become relevant again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will remove the item and block hierarchy, which has many problems with conflicting item and block behaviors and creates a bad system for modding support, which we may want to pursue in the future.
It uses functions to provide default item and block functionality, and provides a simple system mods and plugins can use to extend this functionality and add their own items/blocks with unique functionality in the future.