This repository was archived by the owner on Sep 10, 2022. It is now read-only.
Fix for the ReDOS vulnerability#77
Open
snyk-community wants to merge 1 commit intoGoogleChromeLabs:masterfrom
Open
Fix for the ReDOS vulnerability#77snyk-community wants to merge 1 commit intoGoogleChromeLabs:masterfrom
snyk-community wants to merge 1 commit intoGoogleChromeLabs:masterfrom
Conversation
application-shell is currently affected by the high-severity [ReDOS vulnerability](https://snyk.io/vuln/npm:minimatch:20160620). Vulnerable module: `minimatch` Introduced through: ` browserify` This PR fixes the ReDoS vulnerability by upgrading `browserify` to version 12.0.0 This upgrade will also fix the following other vulnerabilities: * [Command Injection vulnerabilty](https://snyk.io/vuln/npm:shell-quote:20160621) in the `shell-quote` dependency. Check out the [Snyk test report](https://snyk.io/test/github/googlechrome/application-shell) to review other vulnerabilities that affect this repo. [Watch the repo](https://snyk.io/add) to * get alerts if newly disclosed vulnerabilities affect this repo in the future. * generate pull requests with the fixes you want, or let us do the work: when a newly disclosed vulnerability affects you, we'll submit a fix to you right away. Stay secure, The Snyk team
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
application-shell is currently affected by the high-severity ReDOS vulnerability.
Vulnerable module:
minimatchIntroduced through:
browserifyThis PR fixes the ReDoS vulnerability by upgrading
browserifyto version 12.0.0 This upgrade will also fix the following other vulnerabilities:shell-quotedependency.Check out the Snyk test report to review other vulnerabilities that affect this repo.
Watch the repo to
Stay secure,
The Snyk team