-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(secretmanager): Adding secret tag samples #5448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(secretmanager): Adding secret tag samples #5448
Conversation
…es into golang_example
Summary of ChangesHello @khilan-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Google Cloud Secret Manager Go samples by introducing new functionalities for resource tagging. It provides clear examples of how to programmatically bind, list, and detach tags from secrets, including those deployed in specific regions. These additions aim to improve resource organization and management for users by demonstrating key tagging operations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new samples for managing tags on secrets in Secret Manager, covering both global and regional secrets. The additions include functions for binding, detaching, and listing tags, along with comprehensive system tests to validate their functionality. The code is well-structured and the tests are thorough. My main feedback is to ensure that long-running operations are handled by waiting for their completion, which will make the samples more robust and clearer for users.
|
Here is the summary of changes. You are about to add 8 region tags.
This comment is generated by snippet-bot.
|
Adding secret tag samples
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
go test -v ./..(see Testing)gofmt(see Formatting)go vet(see Formatting)