(Feat) custom attribute addition from the UI#6688
Open
krisbiradar wants to merge 4 commits intoGrapesJS:devfrom
Open
(Feat) custom attribute addition from the UI#6688krisbiradar wants to merge 4 commits intoGrapesJS:devfrom
krisbiradar wants to merge 4 commits intoGrapesJS:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Custom Attribute Addition in Trait Manager
🚀 Overview
This feature enhances the Trait Manager by allowing users to dynamically add custom attributes to selected components directly through the editor UI. This removes the need to define every possible trait in the component definition, giving users the flexibility to add attributes like
data-*tags, ARIA labels, or custom identifiers on the fly.📝 Key Changes
1. UI Updates
+).Enteror clicking the button.2. Core Logic
traitscollection.data-id=""), ensuring it appears in the exported code immediately.data-*naming convention (e.g.,data-tooltip).3. Configuration
customTraitValidationRegexto override the default validation pattern.⚙️ Configuration
You can customize the validation logic by passing a regex to the
traitManagerconfiguration.Default Behavior (Strict
data-*attributes):// No config needed, defaults to: /^data-[a-z][a-z0-9-]*$/