fix drag drop cause removing wrong element#6692
Open
them7d wants to merge 1 commit intoGrapesJS:devfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #6666
This PR addresses issues with component sorting and movement by removing visibility filters in BaseComponentNode.
Previously, hidden components were excluded from the children list, which led to incorrect index calculations (cause removing element when invisible element in the same collection) when attempting to move or remove items (resorting the tree).
Additionally, CanvasNewComponentNode has been updated to correctly handle index offsets when checking or moving multiple components (e.g., arrays of content), ensuring that each item is processed at the correct position.
Changes:
BaseComponentNode.ts: Removed getDisplayedChildren, isChildDisplayed, and the isDisplayed helper. getChildren now returns all components from the model, regardless of visibility.
CanvasNewComponentNode.ts: Updated canMove logic to account for the index offset (index + i) when validating moves for array content.