Fix scaling while export#3694
Open
Nuhiat-Arefin wants to merge 5 commits intoGraphiteEditor:masterfrom
Open
Conversation
Update node_graph_executor.rs
Nuhiat-Arefin
force-pushed
the
export_scale
branch
from
e53c6df to
e49c7ee
Compare
Contributor
|
I have fixed the issue for the desktop version from this discussion here , Happy to collaborate on this if you want |
Author
Thanks, happy to collaborate on this |
Contributor
|
Here is the PR , this fixes the desktop issue . Only you can merge this |
fix desktop png / jpeg exports
Author
Cool! Thanks a lot. I think there is a small issue with your code. It cuts the image even with scale factor 1.(in the web app) Screenshot of the image: |
Revert "fix desktop png / jpeg exports"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3588
Earlier, using the scale factor of export configuration inside RenderConfig caused the viewBox to shrink.This meant the renderer produced artwork in a smaller logical coordinate space. Then It drew this small content in a large canvas , scaled up. Thats why we saw only the zoomed-in top-left corner. Now we use scale 1. instead of scale_factor. So the SVG viewBox matches the artwork’s true bounds.scale_factor is only used during calculation of frontend size
Before:
Screen.Recording.2026-01-28.at.1.30.15.AM.mov
After:
Screen.Recording.2026-01-28.at.1.41.18.AM.mov