Fixed CT 'inputs' getter, added 'nonConsumable' getter#1728
Open
TheDarkDnKTv wants to merge 4 commits intoGregTechCE:masterfrom
Open
Fixed CT 'inputs' getter, added 'nonConsumable' getter#1728TheDarkDnKTv wants to merge 4 commits intoGregTechCE:masterfrom
TheDarkDnKTv wants to merge 4 commits intoGregTechCE:masterfrom
Conversation
Caused by creating ItemStack of size 0, which is empty (air).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1439
What
While iterating recipes, in case recipe has non consumable ingredient (count = 0), it will crash. Crafttweaker has check for empty stacks.
How solved:
Added filtration of inputs, to provide only normal ingredients. Non consumables getter was missing, so I added it.
Outcome:
Additional info:
Crash
ZenScript example
Possible compatibility issue:
None, API changes only adds method, and fixing broken logic of one of old.