Reject promise on error in setNetworkProtocols#59
Open
Malvineous wants to merge 1 commit intoGuilhermeC18:masterfrom
Open
Reject promise on error in setNetworkProtocols#59Malvineous wants to merge 1 commit intoGuilhermeC18:masterfrom
Malvineous wants to merge 1 commit intoGuilhermeC18:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you follow the sample code for the
setNetworkProtocolscall, it shows that thecallbackparameter is optional. However if the device returns an error, this function tries to call the callback anyway instead of rejecting the promise.This patch fixes the problem by rejecting the promise in the same way that the other functions do.