Clean up some obsolete CMake version conditions in CMakeLists.txt.#6104
Draft
lrknox wants to merge 2 commits intoHDFGroup:developfrom
Draft
Clean up some obsolete CMake version conditions in CMakeLists.txt.#6104lrknox wants to merge 2 commits intoHDFGroup:developfrom
lrknox wants to merge 2 commits intoHDFGroup:developfrom
Conversation
Improve outdated text in CHANGELOG.md.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
README.md
Outdated
| introduction of new features and the resolution of bugs. However, we aim to have at | ||
| least one annual release for each maintenance branch. | ||
|
|
||
| > The [PR stripping all autotools](https://github.com/HDFGroup/hdf5/pull/5308) was merged into the "develop" branch on **March 10, 2025**. . |
There was a problem hiding this comment.
Remove the extra period after the merge date.
Suggested change
| > The [PR stripping all autotools](https://github.com/HDFGroup/hdf5/pull/5308) was merged into the "develop" branch on **March 10, 2025**. . | |
| > The [PR stripping all autotools](https://github.com/HDFGroup/hdf5/pull/5308) was merged into the "develop" branch on **March 10, 2025**. |
CMakeLists.txt
Outdated
| endif() | ||
| else () | ||
| # H5_LIBVER_DIR is used in HDF5Examples to compile examples from older hdf5 versions. | ||
| # Because the range of minor version numbers exceded single digits, a 0 was needed for |
There was a problem hiding this comment.
Typographical error: "exceded" should be corrected to "exceeded".
Suggested change
| # Because the range of minor version numbers exceded single digits, a 0 was needed for | |
| # Because the range of minor version numbers exceeded single digits, a 0 was needed for |
CMakeLists.txt
Outdated
| else () | ||
| # H5_LIBVER_DIR is used in HDF5Examples to compile examples from older hdf5 versions. | ||
| # Because the range of minor version numbers exceded single digits, a 0 was needed for | ||
| # the single digit minor numbers so that version 2.0 (200) will greater than version |
There was a problem hiding this comment.
Grammatical error: "will greater than version" should be corrected to "will be greater than version".
Suggested change
| # the single digit minor numbers so that version 2.0 (200) will greater than version | |
| # the single digit minor numbers so that version 2.0 (200) will be greater than version |
CMakeLists.txt
Outdated
| #----------------------------------------------------------------------------- | ||
| if (HDF5_ENABLE_PLUGIN_SUPPORT) | ||
| if (${H5_LIBVER_DIR} EQUAL 16 OR HDF5_DEFAULT_API_VERSION MATCHES "v16") | ||
| if HDF5_DEFAULT_API_VERSION MATCHES "v16") |
There was a problem hiding this comment.
Typo: The if condition is missing an opening parenthesis. It should be if (HDF5_DEFAULT_API_VERSION MATCHES "v16") instead of if HDF5_DEFAULT_API_VERSION MATCHES "v16").
Suggested change
| if HDF5_DEFAULT_API_VERSION MATCHES "v16") | |
| if (HDF5_DEFAULT_API_VERSION MATCHES "v16") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve outdated text in CHANGELOG.md.
Important
Clean up obsolete CMake version conditions in
CMakeLists.txtand update outdated text inCHANGELOG.md.CMP0135andHDF5_EXTERNALLY_CONFIGURED.H5_LIBVER_DIR.CHANGELOG.mdto remove outdated references torelease.txtand emphasizeHISTORY*.txtfor previous changes.This description was created by
for ff06eae. You can customize this summary. It will automatically update as commits are pushed.