Downgrading image resolution aspect ratio fix#498
Open
rbrtcs1 wants to merge 1 commit intoHaidra-Org:mainfrom
Open
Downgrading image resolution aspect ratio fix#498rbrtcs1 wants to merge 1 commit intoHaidra-Org:mainfrom
rbrtcs1 wants to merge 1 commit intoHaidra-Org:mainfrom
Conversation
This code attempts to improve the method for downgrading width and height of images. The old method: subtract 64 from width and height until "ok" size. The new method: Scale width and height to exactly max_resolution, maintaining aspect ratio. Then snap down to the nearest multiple of 64. This still doesn't guarantee maintaining the aspect ratio, but it should get much closer in most cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code attempts to improve the method for downgrading width and height of images.
The old method: subtract 64 from width and height until "ok" size.
The new method: Scale width and height to exactly max_resolution, maintaining aspect ratio. Then snap down to the nearest multiple of 64.
This still doesn't guarantee maintaining the aspect ratio, but it should get much closer in most cases.
(I don't have a local instance of this running so I can't test it myself, but the code is fairly straightforward)