[core] Implemented a new sender buffer.#3255
Draft
ethouris wants to merge 19 commits intoHaivision:devfrom
Draft
[core] Implemented a new sender buffer.#3255ethouris wants to merge 19 commits intoHaivision:devfrom
ethouris wants to merge 19 commits intoHaivision:devfrom
Conversation
added 6 commits
November 12, 2025 14:58
…r. Put CSndLossList to CSndBuffer. Explicit save/restore for SndRateMeasurement
…g destructor for CSndBuffer internal container
…ethods in one place. Added unit tests for sender loss handling.
ethouris
added
Type: Maintenance
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
srtcore/buffer_rcv.h
Outdated
Comment on lines
320
to
335
| return CONTINUE; | ||
| } | ||
|
|
||
| size_t hsize() const { return m_entries.size(); } | ||
|
|
||
| //CPos incPos(CPos pos, COff inc = COff(1)) const { return CPos((pos + inc) % hsize()); } | ||
|
|
||
| CPos incPos(CPos position, COff offset = COff(1)) const | ||
| { | ||
| CPos sum = position + offset; | ||
| CPos posmax = hsize(); | ||
| if (sum >= posmax) | ||
| return sum - posmax; | ||
| return sum; | ||
| } | ||
| CPos decPos(CPos pos) const |
Check notice
Code scanning / CodeQL
Commented-out code Note
added 11 commits
December 4, 2025 13:09
added 2 commits
December 12, 2025 13:11
…implemented walkEntries and added test for it. Some fixes from CodeQL reports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new sender buffer is based on
std::dequecontainer, utilizes memory blocks handled byBufferedMessageStorageand the loss schedule is handled on top of the existing cells as linked list of flagged elements.