chore: consolidate color definitions and usage#267
Open
tvolk131 wants to merge 1 commit intoHarborWallet:masterfrom
Open
chore: consolidate color definitions and usage#267tvolk131 wants to merge 1 commit intoHarborWallet:masterfrom
tvolk131 wants to merge 1 commit intoHarborWallet:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Consolidates color definitions by centralizing color constants and removing duplicate color values throughout the codebase.
- Moved color definitions to a centralized location in
components/colors.rs - Replaced hardcoded RGB values with named constants for consistency
- Removed duplicate color helper functions in favor of centralized constants
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| harbor-ui/src/components/colors.rs | Added new color constants and converted existing ones to use from_rgb8 |
| harbor-ui/src/routes/welcome.rs | Replaced hardcoded color with MUTINY_RED constant |
| harbor-ui/src/routes/unlock.rs | Updated imports and replaced hardcoded colors with constants |
| harbor-ui/src/routes/restore.rs | Replaced hardcoded color with MUTINY_RED constant |
| harbor-ui/src/main.rs | Updated theme palette to use centralized color constants |
| harbor-ui/src/components/styles.rs | Removed duplicate color functions and used centralized constants |
| harbor-ui/src/components/screen_header.rs | Replaced color function calls with centralized constants |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| pub fn link() -> Color { | ||
| // This is the same theme.pallette().background just without needing `Theme` | ||
| lighten(Color::from_rgb8(23, 23, 25), 0.7) | ||
| // This is the same theme.palette().background just without needing `Theme` |
There was a problem hiding this comment.
Fixed typo: 'pallette' should be 'palette' in the comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No behavior changes, just de-duplicating color definitions