chore: update iced from 940a079 to 8ba993a#271
Open
tvolk131 wants to merge 1 commit intoHarborWallet:masterfrom
Open
chore: update iced from 940a079 to 8ba993a#271tvolk131 wants to merge 1 commit intoHarborWallet:masterfrom
tvolk131 wants to merge 1 commit intoHarborWallet:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the iced GUI framework from commit 940a079 to 8ba993a, advancing from late February 2025 to late April 2025. The update includes breaking changes that require API adaptations and type updates.
- Update function signatures to use
u32instead ofu16for size parameters - Adapt application initialization API to use default state constructor and separate title method
- Update overlay methods to include viewport parameter and manual palette type conversions
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| harbor-ui/Cargo.toml | Updates iced dependency to newer commit revision |
| harbor-ui/src/main.rs | Adapts application initialization API with default state and title method |
| harbor-ui/src/components/styles.rs | Changes text size parameters from u16 to u32 |
| harbor-ui/src/components/util.rs | Updates palette color conversions to use manual constructors |
| harbor-ui/src/components/toast.rs | Adds viewport parameter to overlay method signature |
| harbor-ui/src/components/indicator.rs | Adds viewport parameter to overlay method signature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the
icedcrate forward from late February 2025 to late April 2025. This requires a handful of changes, listed below. Each item in the list describes the change required in this PR, as well as theicedcommit which requires the change.wgpucrate to v24 by runningcargo update -p wgpu --precise 24.0.5: iced-rs/iced@fb25440palettetypes: iced-rs/iced@44e13dbiced::applicationwith default state, and call.title()to pass in title name instead: iced-rs/iced@fd1101bviewportthrough overlay: iced-rs/iced@6c51a95