Update circle-flags based on square-flags project#108
Closed
kapowaz wants to merge 8 commits intoHatScripts:gh-pagesfrom
Closed
Update circle-flags based on square-flags project#108kapowaz wants to merge 8 commits intoHatScripts:gh-pagesfrom
kapowaz wants to merge 8 commits intoHatScripts:gh-pagesfrom
Conversation
Update all circle flags to latest
Fix some broken gallery URLs
Tweak Malta flag
Further tweaks to circle-flags
Author
|
Closing this in favour of #109. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be a controversial PR, but I thought it was worth sharing!
You may be already aware I have created the square-flags project derived from the original circle-flags icons. There are lots of small improvements I’ve made, initially to cater for the square format, but as I made more and more changes I saw opportunities to improve other things besides:
All of this can continue to exist as its own project, but since I created it as a Figma project I was able to take the work and apply a number of these changes back on the circular format. That’s what this PR is all about.
I’ve created an image which shows the difference between the existing flags and the updated versions in this PR, but you can also see the diff per-flag within the PR: