refactor FlxTypeText to better manage it's current status#470
Open
ninjamuffin99 wants to merge 1 commit intoHaxeFlixel:devfrom
Open
refactor FlxTypeText to better manage it's current status#470ninjamuffin99 wants to merge 1 commit intoHaxeFlixel:devfrom
ninjamuffin99 wants to merge 1 commit intoHaxeFlixel:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bit of some cleanup R&D for FlxTypeText as I've been poking around in it.
I was getting tiny annoyed at 4 different variables to manage paused, typing, erasing, waiting, and the different combination of those, so I organized the logic for that a bit into this
internally something like
becomes
also added a few extra public functions
pause(),resume()andstop()each function is documented
I am trying to get good reps and practice in for lil design / code organization like this, so if it rough around the edges let me know if theres something that should be more consistent with flixel or anything like that!