Open
Conversation
Also added -nocolour due to HXCPP_NO_COLOUR
Simn
reviewed
Dec 10, 2024
Simn
reviewed
Dec 10, 2024
| @@ -1,5 +1,5 @@ | |||
| #ifndef HX_STD_STRING_INCLUDEDED | |||
Member
|
Wow... It's scary how many typos there are. Thanks a lot for looking into this! |
Contributor
|
Do we want to fix typos in the sljit_src folder? That's just vendored sljit source like the other libs in the project/thirdparty folder. |
Member
|
Most of the |
Author
i mean its not included in the .gitattributes as a linguist-vendored so i didnt think of that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added -nocolour due to HXCPP_NO_COLOUR
If there are any typo's you would want me to revert, please do mention below or in a code review, or push a commit to revert that typo
Edit:
i noticed that HXCPP_NO_WASM_EXEPTIONS has a typo
and _hx_reslove_virtual_array also