Support unsigned long values for Dynamic#1214
Open
singpolyma wants to merge 1 commit intoHaxeFoundation:masterfrom
Open
Support unsigned long values for Dynamic#1214singpolyma wants to merge 1 commit intoHaxeFoundation:masterfrom
singpolyma wants to merge 1 commit intoHaxeFoundation:masterfrom
Conversation
singpolyma
force-pushed
the
support-unsigned-long
branch
from
441f720 to
c913af3
Compare
Contributor
|
It looks nice but may break backwards compatibility. |
Author
|
why would it break compatibility? anything using an unsigned long (or equivalent) before would fail to compile |
Contributor
Isn't this change likely to affect the behavior of existing projects? |
Author
|
It shouldn't affect the behaviour of anything existing, except that some that would not compile before will compile now. |
Fixes ambiguous calls when compiling with Xcode
singpolyma
force-pushed
the
support-unsigned-long
branch
from
c913af3 to
ffbb7ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ambiguous calls when compiling with Xcode