Fix cpp.Pointer.ofArray with empty arrays#1262
Open
tobil4sk wants to merge 2 commits intoHaxeFoundation:masterfrom
Open
Fix cpp.Pointer.ofArray with empty arrays#1262tobil4sk wants to merge 2 commits intoHaxeFoundation:masterfrom
tobil4sk wants to merge 2 commits intoHaxeFoundation:masterfrom
Conversation
12 tasks
tobil4sk
force-pushed
the
fix/cpp.Pointer.ofArray-empty
branch
from
7169f46 to
773d932
Compare
array[0] had a side effect of extending an empty array to size 1. Now, the pointer is retrieved directly without the [] access which prevents the array being extended.
tobil4sk
force-pushed
the
fix/cpp.Pointer.ofArray-empty
branch
from
773d932 to
e61e919
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array[0]had a side effect of extending an empty array to size 1. Now,the pointer is retrieved directly without the [] access which prevents
the array being extended.
Fixes #1028.